Skip to content

[8.17] (backport #8605) [Synthetics] Add e2e test for synthetics deps in complete variants #8677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

[8.17] (backport #8605) [Synthetics] Add e2e test for synthetics deps in complete variants #8677

merged 3 commits into from
Jul 1, 2025

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 25, 2025

What does this PR do?

Add tests to check synthetics dependencies for complete variant docker packages. These will prevent the possibility of an unrelated change removing the required dependencies.

Why is it important?

We have seen instances where unrelated changes to the docker template have caused the generated -complete variants to be missing synthetics dependencies.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

  1. Edit elastic-agent docker template sections where synthetics-deps are installed.
  2. Build agent locally.
  3. Wait for testing step to fail.
  4. Restore elastic-agent template.
  5. Build and wait for completion.

Related issues

@emilioalvap @mergify
[Synthetics] Add e2e test for synthetics deps in complete variants (#…
91d7a2e 
…8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/package_test.go
@mergify mergify bot added the backport label Jun 25, 2025
@mergify mergify bot requested a review from a team as a code owner June 25, 2025 18:30
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Jun 25, 2025
@mergify mergify bot removed the request for review from a team June 25, 2025 18:30
@mergify
Copy link
Contributor Author

mergify bot commented Jun 25, 2025

Cherry-pick of f8c1f2e has failed:

On branch mergify/bp/8.17/pr-8605
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit f8c1f2ef0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   dev-tools/packaging/package_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from michalpristas June 25, 2025 18:30
@mergify mergify bot requested a review from swiatekm June 25, 2025 18:30
@mergify mergify bot mentioned this pull request Jun 25, 2025
Merged
5 tasks
@mergify
Copy link
Contributor Author

mergify bot commented Jun 30, 2025

This pull request has not been merged yet. Could you please review and merge it @emilioalvap? 🙏

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Jul 1, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 1, 2025

💚 Build Succeeded

History

cc @emilioalvap

@pkoutsovasilis pkoutsovasilis merged commit 2e5c3f5 into 8.17 Jul 1, 2025
16 of 19 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.17/pr-8605 branch July 1, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@swiatekm swiatekm Awaiting requested review from swiatekm swiatekm is a code owner automatically assigned from elastic/elastic-agent-control-plane

1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emilioalvap emilioalvap

Labels

backport conflicts There is a conflict in the backported pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @pkoutsovasilis @emilioalvap